mkeskells commented on code in PR #3746:
URL: https://github.com/apache/avro/pull/3746#discussion_r3230409728


##########
lang/java/avro/src/main/java/org/apache/avro/file/DataFileStream.java:
##########
@@ -127,7 +151,7 @@ void initialize(InputStream in, byte[] magic) throws 
IOException {
     if (l > 0) {
       do {
         for (long i = 0; i < l; i++) {
-          String key = vin.readString(null).toString();
+          String key = vin.readString();
           ByteBuffer value = vin.readBytes(null);

Review Comment:
   We could reuse the byte buffer, but an impovement in 
https://github.com/apache/avro/pull/3776 removes it anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to