martin-g commented on code in PR #3799:
URL: https://github.com/apache/avro/pull/3799#discussion_r3297917327
##########
lang/c++/CMakeLists.txt:
##########
@@ -89,7 +89,7 @@ if (NOT fmt_FOUND)
FetchContent_Declare(
fmt
GIT_REPOSITORY https://github.com/fmtlib/fmt.git
- GIT_TAG 10.2.1
+ GIT_TAG 12.1.0
Review Comment:
The CI checks pass but
* https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L50
* https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L71-L72
say that it needs C++20.
I guess the build will break with an older C++ compiler (that does not
support 20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
