martin-g commented on code in PR #558:
URL: https://github.com/apache/avro-rs/pull/558#discussion_r3432952557
##########
avro/src/serde/ser_schema/union.rs:
##########
Review Comment:
```suggestion
r#"Expected Schema::Fixed(name: "org.apache.avro.rust.u64",
size: 8) in variants"#,
```
##########
avro/src/serde/ser_schema/union.rs:
##########
Review Comment:
```suggestion
r#"Expected Schema::Fixed(name: "org.apache.avro.rust.i128",
size: 16) in variants"#,
```
It seems there is no test case for this and it was not caught by CI.
##########
avro/src/serde/ser_schema/union.rs:
##########
Review Comment:
```suggestion
r#"Expected Schema::Fixed(name: "org.apache.avro.rust.u128",
size: 16) in variants"#,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
