martin-g commented on code in PR #564:
URL: https://github.com/apache/avro-rs/pull/564#discussion_r3457591357
##########
avro_derive/src/attributes/serde.rs:
##########
@@ -117,8 +117,10 @@ pub struct ContainerAttributes {
pub _default: Option<SerdeDefault>,
/// This type is the serde implementation for a "remote" type.
///
- /// This makes the (de)serialisation use/return a different type.
- pub remote: Option<String>,
+ /// This makes the (de)serialisation use/return a different type. However,
the this type should
+ /// match the other type so the schema we generate is correct.
Review Comment:
It is not clear what `other type` is.
I am saying it as someone who never never needed to use Serde `remote` and I
have not consulted with the Serde docs before making this comment. So, maybe it
is clear enough for people trying to use this attribute.
##########
avro_derive/tests/serde.rs:
##########
@@ -370,6 +370,74 @@ mod container_attributes {
a: vec!["spam".to_string()],
});
}
+
+ #[test]
+ fn avro_rs_562_remote() {
Review Comment:
```suggestion
fn avro_rs_564_remote() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
