Kriskras99 commented on code in PR #561:
URL: https://github.com/apache/avro-rs/pull/561#discussion_r3477333190
##########
avro_derive/src/structs.rs:
##########
@@ -162,9 +187,18 @@ pub fn get_transparent_struct_schema_def(
}
if let Some((field, attrs)) = found {
- Ok((
- field_to_schema_expr(&field, attrs.with.clone())?,
- field_to_record_fields_expr(&field, attrs.with)?,
+ let field_default_expr = if container_attrs.default.is_none() {
Review Comment:
I think you're right, and even stricter: I don't think `default` should be
allowed as a container attribute on a transparent struct, so I've added it to
the deny list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
