mattiabasone commented on code in PR #3708:
URL: https://github.com/apache/avro/pull/3708#discussion_r3559962310
##########
lang/php/lib/Schema/AvroEnumSchema.php:
##########
@@ -72,13 +72,14 @@ public function symbols()
* @return bool true if the given symbol exists in this
* enum schema and false otherwise
*/
- public function hasSymbol($symbol)
+ public function hasSymbol($symbol): bool
{
return in_array($symbol, $this->symbols);
Review Comment:
I've added a strict type check to the method signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
