Kriskras99 commented on code in PR #577:
URL: https://github.com/apache/avro-rs/pull/577#discussion_r3564960262
##########
avro/Cargo.toml:
##########
@@ -57,7 +57,7 @@ crc32fast = { default-features = false, version = "1.5.0",
optional = true }
digest = { default-features = false, version = "0.11.3", features =
["block-api"] }
miniz_oxide = { default-features = false, version = "0.9.1", features =
["with-alloc"] }
log = { workspace = true }
-num-bigint = { default-features = false, version = "0.5.0", features = ["std",
"serde"] }
+num-bigint = { default-features = false, version = "0.4.8", features = ["std",
"serde"] }
Review Comment:
Upgrading `num-bigint` (in #572) is what broke main, the `bigdecimal`
dependency is still on `0.4.8` so the types were incompatible. We should
probably use the re-export provided by `bigdecimal` (if we don't use the type
somewhere else) so we don't have to manually keep upgrading it together with
`bigdecimal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
