iemejia commented on PR #581: URL: https://github.com/apache/avro-rs/pull/581#issuecomment-4951980648
Thanks for the review. Addressed both points in the latest commit: - `safe_collection_len` now uses `checked_mul` (returning `Details::IntegerOverflow`) instead of `saturating_mul`, so a `usize::MAX` allocation budget can't mask a multiplication overflow and let `reserve` panic. - The test helper now builds block-count varints via the crate's `util::zig_i64` encoder instead of a duplicated zigzag/varint implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
