iemejia commented on code in PR #3865:
URL: https://github.com/apache/avro/pull/3865#discussion_r3566777099
##########
lang/java/avro/src/main/java/org/apache/avro/SystemLimitException.java:
##########
@@ -35,6 +35,12 @@
* once single sequence.</li>
* <li><tt>org.apache.avro.limits.string.maxLength</tt></li> limits the maximum
* size of <tt>string</tt> types.</li>
+ * <li><tt>org.apache.avro.limits.collectionItems.maxAllocation</tt></li>
limits
+ * the number of <tt>array</tt> elements whose schema encodes to zero bytes
Review Comment:
Fixed in f2c686f745: corrected the malformed <li> markup (each item was
closing </li> right after the <tt> tag) and the `bytes` property name
(org.apache.avro.limits.bytes.maxLength).
##########
lang/java/avro/src/main/java/org/apache/avro/SystemLimitException.java:
##########
@@ -294,5 +373,7 @@ static void resetLimits() {
maxBytesLength = getLimitFromProperty(MAX_BYTES_LENGTH_PROPERTY,
MAX_ARRAY_VM_LIMIT);
maxCollectionLength = getLimitFromProperty(MAX_COLLECTION_LENGTH_PROPERTY,
MAX_ARRAY_VM_LIMIT);
maxStringLength = getLimitFromProperty(MAX_STRING_LENGTH_PROPERTY,
MAX_ARRAY_VM_LIMIT);
+ maxCollectionAllocation =
getLongLimitFromProperty(MAX_COLLECTION_ALLOCATION_PROPERTY,
+ defaultMaxCollectionAllocation());
Review Comment:
Fixed in f2c686f745: maxCollectionAllocation is now clamped to
MAX_ARRAY_VM_LIMIT when refreshing limits, so a configured/large-heap value
stays consistent with the other collection caps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
