iemejia commented on code in PR #3852:
URL: https://github.com/apache/avro/pull/3852#discussion_r3567365223
##########
lang/js/test/test_files.js:
##########
@@ -531,6 +531,98 @@ describe('files', function () {
});
});
+ it('rejects a block that decompresses beyond the limit', function (cb) {
+ // A large, highly compressible payload compresses to a tiny block but
+ // would decompress to far more than the configured limit.
+ var t = createType('string');
+ var big = new Array(100001).join('a'); // 100000 bytes when decompressed
+ var encoder = new streams.BlockEncoder(t, {codec: 'deflate'});
+ var decoder = new streams.BlockDecoder({maxDecompressLength: 1024})
+ .on('data', function () {})
+ .on('error', function (err) {
+ // zlib's maxOutputLength cap fires, so the allocation itself is
bounded.
+ assert.equal(err.code, 'ERR_BUFFER_TOO_LARGE');
+ cb();
+ });
+ encoder.pipe(decoder);
+ encoder.end(big);
+ });
+
+ it('decompresses a block within the limit', function (cb) {
+ var t = createType('string');
+ var payload = 'hello world';
+ var out = [];
+ var encoder = new streams.BlockEncoder(t, {codec: 'deflate'});
+ var decoder = new streams.BlockDecoder({maxDecompressLength: 1024})
+ .on('data', function (s) { out.push(s); })
+ .on('end', function () {
+ assert.deepEqual(out, [payload]);
+ cb();
+ });
+ encoder.pipe(decoder);
+ encoder.end(payload);
+ });
+
+ it('clamps an out-of-range limit instead of throwing', function (cb) {
Review Comment:
Fixed — renamed to 'falls back to the default limit for an out-of-range
value' and reworded the comment, since `normalizeMaxDecompressLength(Infinity)`
returns `undefined` and the decoder falls back to the default rather than
clamping to the cap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
