martin-g commented on code in PR #586:
URL: https://github.com/apache/avro-rs/pull/586#discussion_r3577509899
##########
avro/src/util.rs:
##########
@@ -73,8 +73,10 @@ impl MapHelper for Map<String, Value> {
}
}
-pub(crate) fn read_long<R: Read>(reader: &mut R) -> AvroResult<i64> {
- zag_i64(reader)
+/// Decode a long from the reader and convert it to a usize.
+pub(crate) fn read_ulong<R: Read>(reader: &mut R) -> AvroResult<usize> {
Review Comment:
```suggestion
pub(crate) fn read_usize<R: Read>(reader: &mut R) -> AvroResult<usize> {
```
`ulong` sounds weird to me.
I guess you want to make it obvious that it reads "an unsigned long" but
then I'd expect `u64`. So, I suggest to just rename it to `read_usize` and use
the docstring to explain more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
