potiuk commented on PR #3905: URL: https://github.com/apache/avro/pull/3905#issuecomment-5268008294
Thanks @steveloughran — that's a fair point and it lands harder here than it would on a normal file, because these two files exist *specifically* to be read by agents. The current ASF header is 17 lines of boilerplate in front of about 12 lines of actual content, so the header is the majority of what a scanner ingests. Hadoop's one-line `<!-- SPDX-License-Identifier: Apache-2.0 -->` is a real improvement on that ratio. Two things I checked before answering, both of which make this the PMC's call rather than mine: - Avro runs `apache-rat-plugin`, so the header has to satisfy RAT, and - there is currently **no** SPDX header anywhere in this repo — this would be the first. So it isn't just a wording swap: it sets a precedent for the repo and needs the RAT config taught to accept the short form. That's a small change, but it's a house-style decision I shouldn't make on the PMC's behalf in a PR that's otherwise deliberately additive-only. Happy either way: 1. **Leave the full header** — consistent with every other file in the repo, costs tokens. 2. **Switch both files to SPDX and update the RAT config in this PR** — I'll make the change and confirm `mvn apache-rat:check` passes before asking for another look. If anyone from the PMC has a preference, say the word and I'll do (2). Otherwise I'd default to (1) purely on the "don't set a repo-wide precedent inside an unrelated PR" principle, and we can do SPDX repo-wide as its own change if it's wanted. And thanks for confirming the content reads straightforwardly — that was the main thing I wanted eyes on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
