martin-g commented on code in PR #642:
URL: https://github.com/apache/avro-rs/pull/642#discussion_r3862089679
##########
avro/src/serde/deser_schema/mod.rs:
##########
@@ -88,8 +94,16 @@ impl<'s, 'r, R: Read, S: Borrow<Schema>>
SchemaAwareDeserializer<'s, 'r, R, S> {
pub fn new(
reader: &'r mut R,
schema: &'s Schema,
- config: Config<'s, S>,
+ mut config: Config<'s, S>,
) -> Result<Self, Error> {
+ // Bound the recursion depth so deeply nested (possibly hostile) data
+ // yields an error instead of exhausting the stack. A recursive schema
+ // lets roughly one wire byte drive one nesting level.
+ config.recursion_depth += 1;
+ let maximum = decode_recursion_limit();
+ if config.recursion_depth > maximum {
+ return Err(Details::DecodeRecursionLimit { maximum }.into());
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
