[
https://issues.apache.org/jira/browse/BEAM-5649?focusedWorklogId=154279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154279
]
ASF GitHub Bot logged work on BEAM-5649:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 12:55
Start Date: 15/Oct/18 12:55
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6689:
[BEAM-5649] Conditionally remove CREATE_VIEW from java generated protos.
URL: https://github.com/apache/beam/pull/6689#discussion_r225154097
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PipelineTranslation.java
##########
@@ -81,8 +96,83 @@ public void visitPrimitiveTransform(Node node) {
.setComponents(components.toComponents())
.addAllRootTransformIds(rootIds)
.build();
+ if (!useDeprecatedViewTransforms) {
+ // TODO(JIRA-5649): Don't even emit these transforms in the generated
protos.
+ res = elideDeprecatedViews(res);
+ }
// Validate that translation didn't produce an invalid pipeline.
PipelineValidator.validate(res);
return res;
}
+
+ private static RunnerApi.Pipeline elideDeprecatedViews(RunnerApi.Pipeline
pipeline) {
+ // Record data on CreateView operations.
+ Collection<String> viewTransforms = new HashSet<>();
Review comment:
No good reason. Updating now. (I'm going to ensure the postcommits pass
before I push.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 154279)
Time Spent: 40m (was: 0.5h)
> Remove deprecated primitive CREATE_VIEW transform from Runner API
> -----------------------------------------------------------------
>
> Key: BEAM-5649
> URL: https://issues.apache.org/jira/browse/BEAM-5649
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The deprecated {{CREATE_VIEW}} transform is still generated as part of the
> Java SDK pipeline construction but not as part of the Python SDK. We had
> previously removed support for the transform in the Portable FlinkRunner
> because end-to-end tests were only run with Python. Since the Java SDK still
> generates the transform we've re-added support for it but would like to
> eventually get it removed.
> This issue tracks removal of the transform from the Runner API. The transform
> can stay in the non-portable Runner pipeline translation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
