[
https://issues.apache.org/jira/browse/BEAM-5626?focusedWorklogId=154395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154395
]
ASF GitHub Bot logged work on BEAM-5626:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 17:50
Start Date: 15/Oct/18 17:50
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6587:
[BEAM-5626] Fix hadoop filesystem test for py3.
URL: https://github.com/apache/beam/pull/6587#discussion_r225258681
##########
File path: sdks/python/apache_beam/io/hadoopfilesystem_test.py
##########
@@ -214,6 +214,11 @@ def setUp(self):
url = self.fs.join(self.tmpdir, filename)
self.fs.create(url).close()
+ try: # Python 2
Review comment:
Thanks for sharing, @HuangLED . I'll link it in [quickstart
guide](https://docs.google.com/document/d/1s1BJVCY65LB_SYK1SU1u7NbZiFANoq-nEYaEvzRbYlA).
Using `sys.version_info[0] == 3` would definitely be a short-sighted check. I
looked at Beam codebase, looks like we rely on it only to skip tests, in other
places we use something like `sys.version_info[0] >= 3`, `sys.version_info[0] <
3`. Although feature detection is ultimately a recommended approach. Moving
forward, we can use feature detection when we can, and add add a comment if
necessary to explain why the check is needed.
FYI @Fematich @Juta @manuzhang @RobbeSneyders @splovyt .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 154395)
Time Spent: 6h (was: 5h 50m)
> Several IO tests fail in Python 3 with RuntimeError('dictionary changed size
> during iteration',)}
> -------------------------------------------------------------------------------------------------
>
> Key: BEAM-5626
> URL: https://issues.apache.org/jira/browse/BEAM-5626
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Ruoyun Huang
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> ERROR: test_delete_dir
> (apache_beam.io.hadoopfilesystem_test.HadoopFileSystemTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/hadoopfilesystem_test.py",
> line 506, in test_delete_dir
> self.fs.delete([url_t1])
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/hadoopfilesystem.py",
> line 370, in delete
> raise BeamIOError("Delete operation failed", exceptions)
> apache_beam.io.filesystem.BeamIOError: Delete operation failed with
> exceptions {'hdfs://test_dir/new_dir1': RuntimeError('dictionary changed size
> during iteration', )}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
