[
https://issues.apache.org/jira/browse/BEAM-5744?focusedWorklogId=154416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154416
]
ASF GitHub Bot logged work on BEAM-5744:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 19:02
Start Date: 15/Oct/18 19:02
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6688:
[BEAM-5744] Cherrypick PR 6686 to 2.8.0. release branch:
URL: https://github.com/apache/beam/pull/6688#discussion_r225281317
##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -223,7 +223,7 @@ def __init__(self,
if target_batch_duration_secs and target_batch_duration_secs <= 0:
raise ValueError("target_batch_duration_secs (%s) must be positive" % (
target_batch_duration_secs))
- if not (target_batch_overhead or target_batch_duration_secs):
Review comment:
Yes we can keep this line. The roll-back PR was auto-generated and merged.
This is a CP of the rollback to release branch. I don't it would make a
difference on the release whether we roll this line forward or not, but we can
roll it forward on master as a part of our Python 3 conversion efforts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 154416)
Time Spent: 1.5h (was: 1h 20m)
> Investigate negative numbers represented as 'long' in Python SDK + Direct
> runner
> --------------------------------------------------------------------------------
>
> Key: BEAM-5744
> URL: https://issues.apache.org/jira/browse/BEAM-5744
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Juta Staes
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
