[
https://issues.apache.org/jira/browse/BEAM-5467?focusedWorklogId=154455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154455
]
ASF GitHub Bot logged work on BEAM-5467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 21:05
Start Date: 15/Oct/18 21:05
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6532:
[BEAM-5467] Use process SDKHarness to run flink PVR tests.
URL: https://github.com/apache/beam/pull/6532#discussion_r225316221
##########
File path: sdks/python/build.gradle
##########
@@ -379,3 +405,21 @@ task buildSnapshot() {
dependsOn 'sdist'
dependsOn 'depSnapshot'
}
+
+project.task('createProcessWorker') {
+ dependsOn ':beam-sdks-python-container:build'
+ dependsOn 'setupVirtualenv'
+ def sdkWorkerFile = file("${project.buildDir}/sdk_worker.sh")
+ def workerScript =
"${project(":beam-sdks-python-container:").buildDir.absolutePath}/target/launcher/linux_amd64/boot"
+ def sdkWorkerFileCode = "sh -c \". ${envdir}/bin/activate && ${workerScript}
\$* \""
Review comment:
The worker script activates a virtual env and executes boot.go in a new
shell where the arguments are passed only to boot.go.
There are 2 challenges to express it as a single command
1. Its really complex to express this multilevel command with right escaping.
2. The command might not be executed correctly as some executor requires the
executable to be an executable and not a shell expression.
Please let me know if you have any suggestion to express it in a better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 154455)
Time Spent: 9h 50m (was: 9h 40m)
> Python Flink ValidatesRunner job fixes
> --------------------------------------
>
> Key: BEAM-5467
> URL: https://issues.apache.org/jira/browse/BEAM-5467
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: portability-flink
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Add status to README
> Rename script and job for consistency
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
