[
https://issues.apache.org/jira/browse/BEAM-5754?focusedWorklogId=154534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154534
]
ASF GitHub Bot logged work on BEAM-5754:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 23:44
Start Date: 15/Oct/18 23:44
Worklog Time Spent: 10m
Work Description: akedin closed pull request #6698: [BEAM-5754] Fix
parentheses grouping warning for beam-sdks-java-io-xml:test
URL: https://github.com/apache/beam/pull/6698
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
index 0a1e70cc529..9d0bd431cf8 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
@@ -1541,7 +1541,7 @@ public int compare(Method o1, Method o2) {
} else {
try {
Class<?> runnerClass = Class.forName(runner, true,
ReflectHelpers.findClassLoader());
- if (!(PipelineRunner.class.isAssignableFrom(runnerClass))) {
+ if (!PipelineRunner.class.isAssignableFrom(runnerClass)) {
throw new IllegalArgumentException(
String.format(
"Class '%s' does not implement PipelineRunner. "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 154534)
Time Spent: 50m (was: 40m)
> beam-sdks-java-io-xml:test target fails in 2.7.0 release
> --------------------------------------------------------
>
> Key: BEAM-5754
> URL: https://issues.apache.org/jira/browse/BEAM-5754
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Environment: java
> Reporter: Ruoyun Huang
> Assignee: Anton Kedin
> Priority: Minor
> Fix For: 2.8.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> some community member reports (in a slack thread) that this test target fails
> in 2.7.0.
> I verified on my computer as well. Same error.
> Not sure how serious it is, just to create this Jira to bring the issue to
> attention. Should be easy to fix.
>
> Error message:
> > Task :beam-sdks-java-core:compileJava
> /usr/local/google/home/ruoyun/projects/beam2/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:1544:
> warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses
> if (!(PipelineRunner.class.isAssignableFrom(runnerClass))) {
> ^
> (see https://errorprone.info/bugpattern/UnnecessaryParentheses)
> Did you mean 'if (!PipelineRunner.class.isAssignableFrom(runnerClass)) {'?
> error: warnings found and -Werror specified
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note:
> /usr/local/google/home/ruoyun/projects/beam2/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
> uses unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 error
> 1 warning
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
