[
https://issues.apache.org/jira/browse/BEAM-4553?focusedWorklogId=154862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154862
]
ASF GitHub Bot logged work on BEAM-4553:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/18 13:28
Start Date: 16/Oct/18 13:28
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #6569: [BEAM-4553]
Implement graphite sink for MetricsPusher and refactor MetricsHttpSink test
URL: https://github.com/apache/beam/pull/6569#issuecomment-430237195
@aromanenko-dev Thanks for your suggestions, I have just finished a big
refactoring to avoid code duplication. It is based now on a Metric Message
class hierarchy. It addresses all your comments. I also replaced the
Thread.sleep in all the metrics sinks tests (including already existing http
metrics sink test) with a CountDownLatch to avoid flakiness of the tests in
case of load. PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 154862)
Time Spent: 5h 10m (was: 5h)
> Implement a Graphite sink for the metrics pusher
> ------------------------------------------------
>
> Key: BEAM-4553
> URL: https://issues.apache.org/jira/browse/BEAM-4553
> Project: Beam
> Issue Type: Sub-task
> Components: runner-extensions-metrics
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Today only a REST Http sink that sends raw json metrics using POST request to
> a http server is available. It is more a POC sink. It would be good to code
> the first real metrics sink. Some of the most popular is Graphite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
