[
https://issues.apache.org/jira/browse/BEAM-4663?focusedWorklogId=155089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155089
]
ASF GitHub Bot logged work on BEAM-4663:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/18 19:49
Start Date: 16/Oct/18 19:49
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#6656: [BEAM-4663] [SQL] CBO cost calculation
URL: https://github.com/apache/beam/pull/6656#discussion_r225684401
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java
##########
@@ -111,6 +114,15 @@ public RelWriter explainTerms(RelWriter pw) {
return pw;
}
+ @Override
+ public RelOptCost computeSelfCost(RelOptPlanner planner, RelMetadataQuery
metadata) {
+ RelNode child = getInput();
+ Double rowCnt = metadata.getRowCount(child);
Review comment:
A `BoundedSource` does have size estimation that we might be able to use.
What I think is important is the ability to correctly guide Calcite to apply
the desired rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155089)
Time Spent: 1h 40m (was: 1.5h)
> Implement Cost calculations for Cost-Based Optimization (CBO)
> --------------------------------------------------------------
>
> Key: BEAM-4663
> URL: https://issues.apache.org/jira/browse/BEAM-4663
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kai Jiang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> To support CBO, we should implement methods in each Beam*Rel.java.
> computeSelfCost(...) as our first step.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
