[
https://issues.apache.org/jira/browse/BEAM-5714?focusedWorklogId=155666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155666
]
ASF GitHub Bot logged work on BEAM-5714:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/18 01:08
Start Date: 18/Oct/18 01:08
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6651: [BEAM-5714] Fix
RedisIO EXEC without MULTI error
URL: https://github.com/apache/beam/pull/6651
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
b/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
index 57d0b77af1f..8a58e2860f8 100644
--- a/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
+++ b/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
@@ -552,6 +552,7 @@ public void processElement(ProcessContext processContext) {
if (batchCount >= DEFAULT_BATCH_SIZE) {
pipeline.exec();
+ pipeline.multi();
batchCount = 0;
}
}
@@ -612,7 +613,9 @@ private void setExpireTimeWhenRequired(String key, Long
expireTime) {
@FinishBundle
public void finishBundle() {
- pipeline.exec();
+ if (pipeline.isInMulti()) {
+ pipeline.exec();
+ }
batchCount = 0;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155666)
Time Spent: 1h (was: 50m)
> RedisIO emit error of EXEC without MULTI
> ----------------------------------------
>
> Key: BEAM-5714
> URL: https://issues.apache.org/jira/browse/BEAM-5714
> Project: Beam
> Issue Type: Bug
> Components: io-java-redis
> Affects Versions: 2.7.0
> Reporter: K.K. POON
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> RedisIO has EXEC without MULTI error after SET a batch of records.
>
> By looking at the source code, I guess there is missing `pipeline.multi();`
> after exec() the last batch.
> [https://github.com/apache/beam/blob/master/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L555]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
