[
https://issues.apache.org/jira/browse/BEAM-2885?focusedWorklogId=156031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156031
]
ASF GitHub Bot logged work on BEAM-2885:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/18 17:04
Start Date: 18/Oct/18 17:04
Worklog Time Spent: 10m
Work Description: herohde closed pull request #6742: [BEAM-2885] Update
graphx/coder.go for temporary edge case
URL: https://github.com/apache/beam/pull/6742
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/pkg/beam/core/runtime/graphx/coder.go
b/sdks/go/pkg/beam/core/runtime/graphx/coder.go
index 7befa6f32ee..6b3f7dd1a44 100644
--- a/sdks/go/pkg/beam/core/runtime/graphx/coder.go
+++ b/sdks/go/pkg/beam/core/runtime/graphx/coder.go
@@ -213,7 +213,9 @@ func (b *CoderUnmarshaller) makeCoder(c *pb.Coder)
(*coder.Coder, error) {
if err != nil {
return nil, err
}
- if elm.GetSpec().GetSpec().GetUrn() != urnCustomCoder {
+ // TODO(lostluck) 2018/10/17: Make this strict again, once
dataflow can use
+ // the portable pipeline model directly (BEAM-2885)
+ if elm.GetSpec().GetSpec().GetUrn() != "" &&
elm.GetSpec().GetSpec().GetUrn() != urnCustomCoder {
// TODO(herohde) 11/17/2017: revisit this restriction
return nil, fmt.Errorf("expected length prefix of
custom coder only: %v", elm)
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 156031)
Time Spent: 4h 50m (was: 4h 40m)
> Local Dataflow proxy for portable job submission
> ------------------------------------------------
>
> Key: BEAM-2885
> URL: https://issues.apache.org/jira/browse/BEAM-2885
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> As per https://s.apache.org/beam-job-api, use local support for
> submission-side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
