[
https://issues.apache.org/jira/browse/BEAM-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658891#comment-16658891
]
Tim Robertson commented on BEAM-5036:
-------------------------------------
Hi [~JozoVilcek]
The solution caused confusion which in itself is an issue - if reviewers don't
understand it, then it will be a problem for us to maintain.
{quote}...to make change only in HDFS filesystem implementation, how do you
propose to do it?
{quote}
Move the retry behaviour from the original PR into the HDFS implementation and
stop throwing FileAlreadyExistsException.
{quote}The WriteOperation.moveToOutput() is now using `FileSystems.copy`, this
would need to change to `rename` anyway, right?
{quote}
Yes
> Optimize FileBasedSink's WriteOperation.moveToOutput()
> ------------------------------------------------------
>
> Key: BEAM-5036
> URL: https://issues.apache.org/jira/browse/BEAM-5036
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Affects Versions: 2.5.0
> Reporter: Jozef Vilcek
> Assignee: Tim Robertson
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
> moveToOutput() methods in FileBasedSink.WriteOperation implements move by
> copy+delete. It would be better to use a rename() which can be much more
> effective for some filesystems.
> Filesystem must support cross-directory rename. BEAM-4861 is related to this
> for the case of HDFS filesystem.
> Feature was discussed here:
> http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
