[ 
https://issues.apache.org/jira/browse/BEAM-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Luckey updated BEAM-5804:
---------------------------------
    Description: 
After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning

{no format}
 
 $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc 
 
 > Task :beam-sdks-java-extensions-sql:compileJavacc
 
 Java Compiler Compiler Version 4.0 (Parser Generator)
 
 (type "javacc" with no arguments for help)
 
 Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
 \{no format}

This is simply due to the fact, that this option does not yet exist in JavaCC 
4.0 [2]

 

So we probably should just remove this option.

[1] https://issues.apache.org/jira/browse/BEAM-4233

[2] 
https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117

  was:
After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning

{no format}

$ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc 

> Task :beam-sdks-java-extensions-sql:compileJavacc

Java Compiler Compiler Version 4.0 (Parser Generator)

(type "javacc" with no arguments for help)

Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.

{no format}

This is simply due to the fact, that this option does not yet exist in JavaCC 
4.0 [2]

 

So we probably should just remove this option.

[1]https://issues.apache.org/jira/browse/BEAM-4233

[2]https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117


> Remove JavaCC bad option warning
> --------------------------------
>
>                 Key: BEAM-5804
>                 URL: https://issues.apache.org/jira/browse/BEAM-5804
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Michael Luckey
>            Assignee: Michael Luckey
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning
> {no format}
>  
>  $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc 
>  
>  > Task :beam-sdks-java-extensions-sql:compileJavacc
>  
>  Java Compiler Compiler Version 4.0 (Parser Generator)
>  
>  (type "javacc" with no arguments for help)
>  
>  Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
>  \{no format}
> This is simply due to the fact, that this option does not yet exist in JavaCC 
> 4.0 [2]
>  
> So we probably should just remove this option.
> [1] https://issues.apache.org/jira/browse/BEAM-4233
> [2] 
> https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to