[
https://issues.apache.org/jira/browse/BEAM-5806?focusedWorklogId=156967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156967
]
ASF GitHub Bot logged work on BEAM-5806:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 18:56
Start Date: 22/Oct/18 18:56
Worklog Time Spent: 10m
Work Description: lhauspie removed a comment on issue #6769: WIP:
[BEAM-5806] Update PubsubIO to be able to change the PubsubClientFactory
URL: https://github.com/apache/beam/pull/6769#issuecomment-431774520
New commits on my branch seems to not trigger new build on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 156967)
Time Spent: 1.5h (was: 1h 20m)
Remaining Estimate: 22.5h (was: 22h 40m)
> Allow to change the PubsubClientFactory when using PubsubIO
> -----------------------------------------------------------
>
> Key: BEAM-5806
> URL: https://issues.apache.org/jira/browse/BEAM-5806
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Logan HAUSPIE
> Assignee: Chamikara Jayalath
> Priority: Minor
> Original Estimate: 24h
> Time Spent: 1.5h
> Remaining Estimate: 22.5h
>
> By using the PubsubIO to read from or write to Pub/Sub we are obliged to use
> the PubsubJsonClient to interact with the Pub/Sub API.
> This PubsubJsonClient encode the message in base 64 and increase the size of
> this one by 30% and there is no way to change the PubsubClient used by
> PubsubIO.
>
> What I suggest is to allow developper to change the PubsubClientFactory by
> specifying it at the definition-time like the following:
> {{^PubsubIO.Read<String> read = PubsubIO.readStrings()
> .fromTopic(StaticValueProvider.of(topic))^}}
> .withTimestampAttribute("myTimestamp")^}}
> .withIdAttribute("myId")^}}
> *.withClientFactory(PubsubGrpcClient.FACTORY)*;^}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
