[
https://issues.apache.org/jira/browse/BEAM-5796?focusedWorklogId=157080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157080
]
ASF GitHub Bot logged work on BEAM-5796:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 19:32
Start Date: 22/Oct/18 19:32
Worklog Time Spent: 10m
Work Description: akedin closed pull request #6758: [BEAM-5796] Test
window_end of TUMBLE, HOP, SESSION
URL: https://github.com/apache/beam/pull/6758
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationTest.java
index 7fd5718523c..95ec4cc97aa 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslAggregationTest.java
@@ -325,7 +325,8 @@ public void testTumbleWindowWithUnbounded() throws
Exception {
private void runTumbleWindow(PCollection<Row> input) throws Exception {
String sql =
"SELECT f_int2, COUNT(*) AS `getFieldCount`,"
- + " TUMBLE_START(f_timestamp, INTERVAL '1' HOUR) AS `window_start`"
+ + " TUMBLE_START(f_timestamp, INTERVAL '1' HOUR) AS
`window_start`, "
+ + " TUMBLE_END(f_timestamp, INTERVAL '1' HOUR) AS `window_end` "
+ " FROM TABLE_A"
+ " GROUP BY f_int2, TUMBLE(f_timestamp, INTERVAL '1' HOUR)";
PCollection<Row> result =
@@ -337,6 +338,7 @@ private void runTumbleWindow(PCollection<Row> input) throws
Exception {
.addInt32Field("f_int2")
.addInt64Field("size")
.addDateTimeField("window_start")
+ .addDateTimeField("window_end")
.build();
List<Row> expectedRows =
@@ -345,9 +347,11 @@ private void runTumbleWindow(PCollection<Row> input)
throws Exception {
0,
3L,
FORMAT.parseDateTime("2017-01-01 01:00:00"),
+ FORMAT.parseDateTime("2017-01-01 02:00:00"),
0,
1L,
- FORMAT.parseDateTime("2017-01-01 02:00:00"))
+ FORMAT.parseDateTime("2017-01-01 02:00:00"),
+ FORMAT.parseDateTime("2017-01-01 03:00:00"))
.getRows();
PAssert.that(result).containsInAnyOrder(expectedRows);
@@ -429,7 +433,8 @@ public void testHopWindowWithUnbounded() throws Exception {
private void runHopWindow(PCollection<Row> input) throws Exception {
String sql =
"SELECT f_int2, COUNT(*) AS `getFieldCount`,"
- + " HOP_START(f_timestamp, INTERVAL '30' MINUTE, INTERVAL '1'
HOUR) AS `window_start`"
+ + " HOP_START(f_timestamp, INTERVAL '30' MINUTE, INTERVAL '1'
HOUR) AS `window_start`, "
+ + " HOP_END(f_timestamp, INTERVAL '30' MINUTE, INTERVAL '1' HOUR)
AS `window_end` "
+ " FROM PCOLLECTION"
+ " GROUP BY f_int2, HOP(f_timestamp, INTERVAL '30' MINUTE,
INTERVAL '1' HOUR)";
PCollection<Row> result = input.apply("testHopWindow",
SqlTransform.query(sql));
@@ -439,6 +444,7 @@ private void runHopWindow(PCollection<Row> input) throws
Exception {
.addInt32Field("f_int2")
.addInt64Field("size")
.addDateTimeField("window_start")
+ .addDateTimeField("window_end")
.build();
List<Row> expectedRows =
@@ -447,15 +453,19 @@ private void runHopWindow(PCollection<Row> input) throws
Exception {
0,
3L,
FORMAT.parseDateTime("2017-01-01 00:30:00"),
+ FORMAT.parseDateTime("2017-01-01 01:30:00"),
0,
3L,
FORMAT.parseDateTime("2017-01-01 01:00:00"),
+ FORMAT.parseDateTime("2017-01-01 02:00:00"),
0,
1L,
FORMAT.parseDateTime("2017-01-01 01:30:00"),
+ FORMAT.parseDateTime("2017-01-01 02:30:00"),
0,
1L,
- FORMAT.parseDateTime("2017-01-01 02:00:00"))
+ FORMAT.parseDateTime("2017-01-01 02:00:00"),
+ FORMAT.parseDateTime("2017-01-01 03:00:00"))
.getRows();
PAssert.that(result).containsInAnyOrder(expectedRows);
@@ -478,7 +488,8 @@ public void testSessionWindowWithUnbounded() throws
Exception {
private void runSessionWindow(PCollection<Row> input) throws Exception {
String sql =
"SELECT f_int2, COUNT(*) AS `getFieldCount`,"
- + " SESSION_START(f_timestamp, INTERVAL '5' MINUTE) AS
`window_start`"
+ + " SESSION_START(f_timestamp, INTERVAL '5' MINUTE) AS
`window_start`, "
+ + " SESSION_END(f_timestamp, INTERVAL '5' MINUTE) AS `window_end` "
+ " FROM TABLE_A"
+ " GROUP BY f_int2, SESSION(f_timestamp, INTERVAL '5' MINUTE)";
PCollection<Row> result =
@@ -490,6 +501,7 @@ private void runSessionWindow(PCollection<Row> input)
throws Exception {
.addInt32Field("f_int2")
.addInt64Field("size")
.addDateTimeField("window_start")
+ .addDateTimeField("window_end")
.build();
List<Row> expectedRows =
@@ -498,8 +510,10 @@ private void runSessionWindow(PCollection<Row> input)
throws Exception {
0,
3L,
FORMAT.parseDateTime("2017-01-01 01:01:03"),
+ FORMAT.parseDateTime("2017-01-01 01:01:03"),
0,
1L,
+ FORMAT.parseDateTime("2017-01-01 02:04:03"),
FORMAT.parseDateTime("2017-01-01 02:04:03"))
.getRows();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157080)
Time Spent: 40m (was: 0.5h)
> TEST window_end for TUMBLE, HOP, SESSION
> ----------------------------------------
>
> Key: BEAM-5796
> URL: https://issues.apache.org/jira/browse/BEAM-5796
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
