[
https://issues.apache.org/jira/browse/BEAM-5800?focusedWorklogId=157185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157185
]
ASF GitHub Bot logged work on BEAM-5800:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 20:43
Start Date: 22/Oct/18 20:43
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6760:
[BEAM-5800] Support WordCountIT using fn-api worker
URL: https://github.com/apache/beam/pull/6760#discussion_r227107800
##########
File path: runners/google-cloud-dataflow-java/examples/build.gradle
##########
@@ -56,3 +60,41 @@ task preCommit(type: Test) {
maxParallelForks 4
systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(preCommitBeamTestPipelineOptions)
}
+
+project.rootProject.ext.set("docker-repository-root", "${dockerImageRoot}")
Review comment:
When this project is evaluated, it will override any properties users may
have configured.
You'll need to restructure the `buildAndPushDockerContainer` task such that
you can get the image/tag as a property of the
`:beam-sdks-java-container:docker` run.
Also, why are we not using `dockerPush` part of the gradle docker plugin
(https://github.com/palantir/gradle-docker)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157185)
Time Spent: 20m (was: 10m)
> Support WordCountIT using fn-api worker
> ---------------------------------------
>
> Key: BEAM-5800
> URL: https://issues.apache.org/jira/browse/BEAM-5800
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
