[ 
https://issues.apache.org/jira/browse/BEAM-5637?focusedWorklogId=157781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157781
 ]

ASF GitHub Bot logged work on BEAM-5637:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Oct/18 19:26
            Start Date: 23/Oct/18 19:26
    Worklog Time Spent: 10m 
      Work Description: HuangLED edited a comment on issue #6680: [BEAM-5637] 
Python support for custom dataflow worker jar
URL: https://github.com/apache/beam/pull/6680#issuecomment-432365710
 
 
   > How does this interact with installing the packages in boot.go. Would not 
this 
(https://github.com/apache/beam/blob/master/sdks/python/container/boot.go#L104) 
fail?
   
   A quick update after tracing the code. @aaltay  Got the issue pinned with 
hints from @herohde.  
   
   The external python boot.go does not need further change, because it lists 
all the depended files explicitly, thus is already error-proof when an expected 
file exists. 
   
   Multiple choices regarding how to align this effort with the worker image 
migration, as well as some other integration testing migrations.  Let me dive 
into this a bit more and get back soon. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 157781)
    Time Spent: 6h  (was: 5h 50m)

> Python support for custom dataflow worker jar
> ---------------------------------------------
>
>                 Key: BEAM-5637
>                 URL: https://issues.apache.org/jira/browse/BEAM-5637
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Henning Rohde
>            Assignee: Ruoyun Huang
>            Priority: Major
>          Time Spent: 6h
>  Remaining Estimate: 0h
>
> One of the slightly subtle aspects is that we would need to ignore one of the 
> staged jars for portable Python jobs. That requires a change to the Python 
> boot code: 
> https://github.com/apache/beam/blob/66d7c865b7267f388ee60752891a9141fad43774/sdks/python/container/boot.go#L104



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to