[ 
https://issues.apache.org/jira/browse/BEAM-5833?focusedWorklogId=157830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157830
 ]

ASF GitHub Bot logged work on BEAM-5833:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Oct/18 21:10
            Start Date: 23/Oct/18 21:10
    Worklog Time Spent: 10m 
      Work Description: swegner commented on issue #6798: [BEAM-5833] Fix 
checkstyle breakage
URL: https://github.com/apache/beam/pull/6798#issuecomment-432421154
 
 
   Thanks for fixing this.
   
   re: Merging before pre-commits finish: it's currently a pain-point to 
validate that a set of changes fix an existing breakage because pre-commits and 
post-commits take so long to run.
   
   I've heard some solutions proposed: make test suites more granular, add 
Jenkins triggering for a subset of tests.
   
   Until we have test suites that run sufficiently fast, I think it should be 
sufficient to verify locally and post a green build scan. (i.e. execute Gradle 
using the `--scan` flag and comment with the URL)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 157830)
    Time Spent: 40m  (was: 0.5h)

> Java precommit broken by CloseableFnDataReceiver#flush as well as Spotless 
> failures
> -----------------------------------------------------------------------------------
>
>                 Key: BEAM-5833
>                 URL: https://issues.apache.org/jira/browse/BEAM-5833
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-harness, test-failures
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> https://builds.apache.org/job/beam_PreCommit_Java_Cron/498/
> https://scans.gradle.com/s/big7mxohgz2ry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to