[
https://issues.apache.org/jira/browse/BEAM-5817?focusedWorklogId=158033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158033
]
ASF GitHub Bot logged work on BEAM-5817:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 08:59
Start Date: 24/Oct/18 08:59
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #6780:
[BEAM-5817] Use an explicit enum for naming Nexmark benchmarks
URL: https://github.com/apache/beam/pull/6780#discussion_r227685528
##########
File path:
sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java
##########
@@ -186,7 +186,14 @@ public void overrideFromOptions(NexmarkOptions options) {
debug = options.getDebug();
}
if (options.getQuery() != null) {
- query = options.getQuery();
+ try {
+ query = NexmarkQueryName.valueOf(options.getQuery());
+ } catch (IllegalArgumentException exc) {
Review comment:
If I understand properly, user can specify either `--query=3` or
`--query=THREE` and it should end up being the same `NexmarkConfiguration`
containing `NexmarkQueryName.THREE`. And you use the exception to differentiate
between the two cases. Right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158033)
Time Spent: 1h 10m (was: 1h)
> Nexmark test of joining stream to files
> ---------------------------------------
>
> Key: BEAM-5817
> URL: https://issues.apache.org/jira/browse/BEAM-5817
> Project: Beam
> Issue Type: New Feature
> Components: examples-nexmark
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Nexmark is a convenient framework for testing the use case of large scale
> stream enrichment. One way is joining a stream to files, and it can be tested
> via any source that Nexmark supports.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
