[
https://issues.apache.org/jira/browse/BEAM-2918?focusedWorklogId=158153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158153
]
ASF GitHub Bot logged work on BEAM-2918:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 13:59
Start Date: 24/Oct/18 13:59
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6726:
[BEAM-2918] Add state support for streaming in portable FlinkRunner
URL: https://github.com/apache/beam/pull/6726#discussion_r227800284
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -135,6 +136,9 @@ public ExecutableStageDoFnOperator(
this.contextFactory = contextFactory;
this.outputMap = outputMap;
this.sideInputIds = sideInputIds;
+
+ // Never chain because chaining could break concurrent element processing
and state access
+ setChainingStrategy(ChainingStrategy.NEVER);
Review comment:
This doesn't look quite right yet:
There are legitimate cases for chaining with different operator upstream of
the executable stage (such as a native transform like the Kinesis consumer)
It is only a concern for executable stages that use stateful processing. If
KeyedStateBackend is shared between operators in a chain, then we should set
the chaining strategy only in such case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158153)
Time Spent: 10h 50m (was: 10h 40m)
> Flink support for portable user state
> -------------------------------------
>
> Key: BEAM-2918
> URL: https://issues.apache.org/jira/browse/BEAM-2918
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Henning Rohde
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
