[
https://issues.apache.org/jira/browse/BEAM-5745?focusedWorklogId=158283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158283
]
ASF GitHub Bot logged work on BEAM-5745:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 19:47
Start Date: 24/Oct/18 19:47
Worklog Time Spent: 10m
Work Description: HuangLED commented on a change in pull request #6687:
[BEAM-5745] Fix annotation test for py3
URL: https://github.com/apache/beam/pull/6687#discussion_r227934912
##########
File path: sdks/python/apache_beam/utils/annotations_test.py
##########
@@ -32,9 +32,12 @@ def test_deprecated_with_since_current_message(self):
@deprecated(since='v.1', current='multiply', extra_message='Do this')
def fnc_test_deprecated_with_since_current_message():
return 'lol'
+ # In python2, the test framework by default adds an ignore filtering
rule.
Review comment:
Acked. Thanks.
Though this PR is now in conflict with another non-trivial merge. Does not
seem trivial to get all resolved.
Please let me know if there is any way better than copy over the master
version and apply all my changes again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158283)
Time Spent: 3h 40m (was: 3.5h)
> Util test on annotations fails
> -------------------------------
>
> Key: BEAM-5745
> URL: https://issues.apache.org/jira/browse/BEAM-5745
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Traceback (most recent call last):
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 142, in test_frequency
> label_check_list=[])
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 149, in check_annotation
> self.assertIn(fnc_name + ' is ' + annotation_type,
> str(warning[-1].message))
> AssertionError: 'fnc2_test_annotate_frequency is experimental' not found in
> 'fnc_test_annotate_frequency is experimental.'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
