[
https://issues.apache.org/jira/browse/BEAM-5837?focusedWorklogId=158396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158396
]
ASF GitHub Bot logged work on BEAM-5837:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 23:38
Start Date: 24/Oct/18 23:38
Worklog Time Spent: 10m
Work Description: Ardagan commented on a change in pull request #6820:
[BEAM-5837] Add dashboard for monitoring input data staleness
URL: https://github.com/apache/beam/pull/6820#discussion_r227994483
##########
File path: .test-infra/metrics/src/test/groovy/ProberTests.groovy
##########
@@ -36,7 +38,17 @@ class ProberTests {
def dashboardNames = allDashboards.title
// Validate at least one expected dashboard exists
assert dashboardNames.contains('Post-commit Tests') : 'Expected dashboard
does not exist'
- assert dashboardNames.size >= 3 : "Number of dashboards is less than
expected ${dashboardNames}"
+ assert dashboardNames.size >= 4 : "Number of dashboards is less than
expected ${dashboardNames}"
Review comment:
This test is too strict. Will fire false alarms on each code deployment or
change.
```suggestion
assert dashboardNames.size > 0 : "No dashboards found. Check Grafana
dashboard initialization script."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158396)
Time Spent: 2h (was: 1h 50m)
> Add monitoring for community metrics pipeline
> ---------------------------------------------
>
> Key: BEAM-5837
> URL: https://issues.apache.org/jira/browse/BEAM-5837
> Project: Beam
> Issue Type: Sub-task
> Components: project-management
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> For the new community metrics infrastructure, we need to build some
> monitoring that can check the pipeline and make sure it's healthy.
> This could be implemented as a Jenkins job which can:
> * Probe the Grafana dashboard URL to ensure Grafana is up
> * Query some data from postgres to ensure the data is recent
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
