[
https://issues.apache.org/jira/browse/BEAM-5812?focusedWorklogId=158861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158861
]
ASF GitHub Bot logged work on BEAM-5812:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/18 19:30
Start Date: 25/Oct/18 19:30
Worklog Time Spent: 10m
Work Description: herohde closed pull request #6824: [BEAM-5812] Increase
wait time for Dataflow job start/cancel
URL: https://github.com/apache/beam/pull/6824
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
b/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
index 8c61f104e39..b1a845a2784 100644
--- a/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
+++ b/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
@@ -32,7 +32,9 @@
__all__ = ['TestDataflowRunner']
-WAIT_TIMEOUT = 2 * 60
+# Dataflow take up to 10mins for the long tail of starting/stopping worker
+# pool.
+WAIT_IN_STATE_TIMEOUT = 10 * 60
class TestDataflowRunner(DataflowRunner):
@@ -51,7 +53,7 @@ def run_pipeline(self, pipeline):
if self.result.has_job:
# TODO(markflyhigh)(BEAM-1890): Use print since Nose dosen't show logs
# in some cases.
- print('Found: %s.' % self.build_console_url(pipeline.options))
+ print('Found: %s.' % self.build_console_url(options))
try:
self.wait_until_in_state(PipelineState.RUNNING)
@@ -66,7 +68,7 @@ def run_pipeline(self, pipeline):
finally:
if not self.result.is_in_terminal_state():
self.result.cancel()
- self.wait_until_in_state(PipelineState.CANCELLED, timeout=300)
+ self.wait_until_in_state(PipelineState.CANCELLED)
return self.result
@@ -79,8 +81,8 @@ def build_console_url(self, options):
'https://console.cloud.google.com/dataflow/jobsDetail/locations'
'/%s/jobs/%s?project=%s' % (region_id, job_id, project))
- def wait_until_in_state(self, expected_state, timeout=WAIT_TIMEOUT):
- """Wait until Dataflow pipeline terminate or enter RUNNING state."""
+ def wait_until_in_state(self, expected_state, timeout=WAIT_IN_STATE_TIMEOUT):
+ """Wait until Dataflow pipeline enters a certain state."""
if not self.result.has_job:
raise IOError('Failed to get the Dataflow job id.')
@@ -93,5 +95,5 @@ def wait_until_in_state(self, expected_state,
timeout=WAIT_TIMEOUT):
raise RuntimeError('Timeout after %d seconds while waiting for job %s '
'enters expected state %s. Current state is %s.' %
- (WAIT_TIMEOUT, self.result.job_id,
+ (timeout, self.result.job_id(),
expected_state, self.result.state))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158861)
Time Spent: 0.5h (was: 20m)
> Timeout in Python ITs: WordCountIT (fn api and legacy), HourlyTeamScoreIT,
> FastavroIT
> -------------------------------------------------------------------------------------
>
> Key: BEAM-5812
> URL: https://issues.apache.org/jira/browse/BEAM-5812
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Kenneth Knowles
> Assignee: Valentyn Tymofieiev
> Priority: Critical
> Labels: flake
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [https://builds.apache.org/job/beam_PostCommit_Python_Verify/6341/]
> [https://scans.gradle.com/s/ivjuxhni54azk/console-log?task=:beam-sdks-python:postCommitITTests]
> I don't see anything about these tests that would say much. It could be
> environmental but it might just imply that all the timeouts should be higher
> if they are sensitive, or their was (and continues to be) an outage of some
> sort.
> Assignee chosen because I see you as reviewer of avro changes and author of
> other changes to the py sdk in the last few days. If you have no idea, that's
> fine, I just didn't want to leave it unassigned.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
