[ 
https://issues.apache.org/jira/browse/BEAM-5853?focusedWorklogId=159016&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159016
 ]

ASF GitHub Bot logged work on BEAM-5853:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/18 07:22
            Start Date: 26/Oct/18 07:22
    Worklog Time Spent: 10m 
      Work Description: robertwb closed pull request #6837: [BEAM-5853] 
Possible fix in RemoteGrpcPortWriteOperation
URL: https://github.com/apache/beam/pull/6837
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/data/RemoteGrpcPortWriteOperation.java
 
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/data/RemoteGrpcPortWriteOperation.java
index 65cffd0ce5b..d128f2306ef 100644
--- 
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/data/RemoteGrpcPortWriteOperation.java
+++ 
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/data/RemoteGrpcPortWriteOperation.java
@@ -120,11 +120,10 @@ boolean shouldWait() throws Exception {
       }
       int numProcessed = elementsProcessed.get();
       // A negative value indicates that obtaining numProcessed is not 
supported.
+      // Otherwise, wait until the SDK has processed at least one element 
before continuing.
       if (numProcessed < 0) {
         targetElementsSent = Integer.MAX_VALUE;
-      }
-      // Wait until the SDK has processed at least one element before 
continuing.
-      if (numProcessed == 0) {
+      } else if (numProcessed == 0) {
         targetElementsSent = 1;
       } else {
         double rate;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 159016)
    Time Spent: 20m  (was: 10m)

> PR6752 cause WindowedWordCount fn-api worker pipeline stuck
> -----------------------------------------------------------
>
>                 Key: BEAM-5853
>                 URL: https://issues.apache.org/jira/browse/BEAM-5853
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, sdk-java-harness
>            Reporter: Boyuan Zhang
>            Assignee: Robert Bradshaw
>            Priority: Major
>         Attachments: log.png, log1.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/beam/pull/6752] caused fn-api worker windowed 
> wordcount pipeline got stucked in sdk harness:



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to