[
https://issues.apache.org/jira/browse/BEAM-5815?focusedWorklogId=159297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159297
]
ASF GitHub Bot logged work on BEAM-5815:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/18 18:25
Start Date: 26/Oct/18 18:25
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6842: [BEAM-5815] Update
precommit triage guide for new dashboard
URL: https://github.com/apache/beam/pull/6842
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/website/src/contribute/precommit-triage-guide.md
b/website/src/contribute/precommit-triage-guide.md
index e1ba1e08636..6b48e78f7f6 100644
--- a/website/src/contribute/precommit-triage-guide.md
+++ b/website/src/contribute/precommit-triage-guide.md
@@ -44,30 +44,16 @@ There are two main signs of slowness:
1. Pre-commit jobs are timing out after 30 minutes. This can be determined from
the console log of a job.
1. Pre-commits aren't timing out, but the total wait time for pre-commit
results
- is >30m. This can be determined using a Jupyter notebook.
+ is >30m.
-### Notebook
+### Pre-commit Dashboard
-The Beam repo contains a [Jupyter
-notebook](https://github.com/apache/beam/tree/master/.test-infra/jupyter) named
-`precommit_job_times.ipynb` that can be used to gather and visualize statistics
-about pre-commit running times.
+The Beam Community Metrics site contains a [Pre-Commit
+Tests](http://104.154.241.245/d/_TNndF2iz/pre-commit-tests) dashboard showing
+job timing trends. You can modify the time window (defaults to 7 days) or
filter
+down to a specific test suite by clicking on it.
-Run the notebook. It should output a table with running times. The numbers in
-the column `totalDurationMinutes_all` and the rows with a `job_name` like `4
-weeks 95th` contain the target numbers for determining slowness.
-If any of these numbers are above 30, triaging is required.
-
-#### Example
-Here's an example table of running times:
-
-
-
-(Note that this example was created when pre-commits did not have 30m
timeouts.)
-
-In this example, Go pre-commits are taking approximately 14 minutes, which is
-fast. Java and Python pre-commits are taking 78 and 32 minutes respectively,
-which is slow. Both Java and Python pre-commits require triage.
+
## Triage Process
diff --git a/website/src/images/precommit_dashboard.png
b/website/src/images/precommit_dashboard.png
new file mode 100644
index 00000000000..49e4065e2fc
--- /dev/null
+++ b/website/src/images/precommit_dashboard.png
@@ -0,0 +1,31 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <meta name="robots" content="noindex">
+ <title>Sign in - Google Accounts</title>
+ <meta http-equiv="refresh" content="1;
url=https://www.google.com/accounts/AccountChooser?hd=google.com&continue=https%3A%2F%2Fappengine.google.com%2F_ah%2Fconflogin%3Fcontinue%3Dhttps%3A%2F%2Fscreenshot.googleplex.com%2Fu5CALdM0vvL.png&service=ah";></meta>
+ </head>
+ <body >
+ <form id="hiddenget"
action="https://www.google.com/accounts/AccountChooser?hd=google.com&continue=https%3A%2F%2Fappengine.google.com%2F_ah%2Fconflogin%3Fcontinue%3Dhttps%3A%2F%2Fscreenshot.googleplex.com%2Fu5CALdM0vvL.png&service=ah";
method="get">
+ <noscript>
+ You should turn on Javascript support.
+ <input type="submit" id="nojssubmit" value="Continue">
+ </noscript>
+</form>
+ <script nonce="ltS697Ql5dRzrGv5NV4wXk0ybRU">
+window.onload = function() {
+ var redirectUrl =
'https:\x2F\x2Fwww.google.com\x2Faccounts\x2FAccountChooser?hd=google.com\x26continue=https%3A%2F%2Fappengine.google.com%2F_ah%2Fconflogin%3Fcontinue%3Dhttps%3A%2F%2Fscreenshot.googleplex.com%2Fu5CALdM0vvL.png\x26service=ah';
+ var domain = 'google.com';
+ var hash = window.location.hash;
+ if (hash) {
+ var match = hash.match(/[#&]Email=([^&]+)/);
+ if (match) {
+ redirectUrl += "&Email=" + match[1] + "@" + domain;
+ }
+ }
+ window.location.replace(redirectUrl);
+};
+</script>
+ </body>
+</html>
diff --git a/website/src/images/precommit_durations.png
b/website/src/images/precommit_durations.png
deleted file mode 100644
index c6596772924..00000000000
Binary files a/website/src/images/precommit_durations.png and /dev/null differ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 159297)
Time Spent: 0.5h (was: 20m)
> Update pre-commit slowness triage guide for Grafana
> ---------------------------------------------------
>
> Key: BEAM-5815
> URL: https://issues.apache.org/jira/browse/BEAM-5815
> Project: Beam
> Issue Type: Sub-task
> Components: testing, website
> Reporter: Scott Wegner
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, the [Pre-commit Slowness Triage
> Guide|https://beam.apache.org/contribute/precommit-triage-guide/] has
> instructions on tabulating the most recent post-commit durations from a
> Jupyter notebook. The tracking metrics for this have since been migrated to
> [Grafana|http://104.154.241.245/d/_TNndF2iz/pre-commit-tests?orgId=1]. We
> should update the triage guide to point to this new source.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
![https://www.google.com/accounts/AccountChooser?hd=google.com&continue=https%3A%2F%2Fappengine.google.com%2F_ah%2Fconflogin%3Fcontinue%3Dhttps%3A%2F%2Fscreenshot.googleplex.com%2Fu5CALdM0vvL.png&service=ah"](https://www.google.com/accounts/AccountChooser?hd=google.com&continue=https%3A%2F%2Fappengine.google.com%2F_ah%2Fconflogin%3Fcontinue%3Dhttps%3A%2F%2Fscreenshot.googleplex.com%2Fu5CALdM0vvL.png&service=ah"){kind=link}