[
https://issues.apache.org/jira/browse/BEAM-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665816#comment-16665816
]
Valentyn Tymofieiev commented on BEAM-5322:
-------------------------------------------
Thanks for the feedback, [~robertwb].
One issue with typehints is that we [monkey-patch
inspect.getargspec|https://github.com/apache/beam/blob/52721a1fabc95fe0e26fbb8b6338ae75f773ec8c/sdks/python/apache_beam/typehints/decorators.py#L118],
and rely on the fact that inspect.getcallargs will use a patched
implementation. However getargspec is deprecated in favor of getfullargspec,
and new implementation of getcallargs [uses
getfullargspec|https://github.com/python/cpython/blob/cd1d5c554c40b5b348de2e77d65986aa154e4477/Lib/inspect.py#L1171].
> Finish Python 3 porting for typehints module
> --------------------------------------------
>
> Key: BEAM-5322
> URL: https://issues.apache.org/jira/browse/BEAM-5322
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
