[
https://issues.apache.org/jira/browse/BEAM-3573?focusedWorklogId=160217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160217
]
ASF GitHub Bot logged work on BEAM-3573:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 21:33
Start Date: 29/Oct/18 21:33
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #6838: [BEAM-3573] Move
GCPIO test utilities to main jar
URL: https://github.com/apache/beam/pull/6838
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/examples/java/build.gradle b/examples/java/build.gradle
index 4207ae56e01..4d98ba68a6e 100644
--- a/examples/java/build.gradle
+++ b/examples/java/build.gradle
@@ -63,8 +63,9 @@ dependencies {
shadow library.java.slf4j_api
shadow library.java.slf4j_jdk14
runtime project(path: ":beam-runners-direct-java", configuration: "shadow")
- shadowTest project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadowTest")
+ shadowTest project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
shadowTest library.java.hamcrest_core
+ shadowTest library.java.hamcrest_library
shadowTest library.java.junit
shadowTest library.java.mockito_core
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
similarity index 100%
rename from
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
rename to
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
similarity index 98%
rename from
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
rename to
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
index 36354fb5448..5c4e324ae0b 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
+++
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
@@ -35,6 +35,7 @@
import javax.annotation.Nonnull;
import javax.annotation.concurrent.NotThreadSafe;
import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.annotations.Experimental;
import org.apache.beam.sdk.testing.SerializableMatcher;
import org.hamcrest.Description;
import org.hamcrest.TypeSafeMatcher;
@@ -52,6 +53,7 @@
* ]}</pre>
*/
@NotThreadSafe
+@Experimental
public class BigqueryMatcher extends TypeSafeMatcher<PipelineResult>
implements SerializableMatcher<PipelineResult> {
private static final Logger LOG =
LoggerFactory.getLogger(BigqueryMatcher.class);
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/package-info.java
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/package-info.java
similarity index 100%
rename from
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/testing/package-info.java
rename to
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/package-info.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160217)
Time Spent: 1h 20m (was: 1h 10m)
> Test jars should export only tests, and only be exported for select modules
> ---------------------------------------------------------------------------
>
> Key: BEAM-3573
> URL: https://issues.apache.org/jira/browse/BEAM-3573
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Today, we have test-jars that are used as libraries for testing. That is not
> what "test jar" means, and dependency management actually does not work
> correctly for this. It is OK to depend on a test jar in order to run the
> tests therein, and not really OK to depend on one for another reason.
> This ticket is a bucket ticket for fixes to this situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
