[
https://issues.apache.org/jira/browse/BEAM-5875?focusedWorklogId=160880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160880
]
ASF GitHub Bot logged work on BEAM-5875:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 21:45
Start Date: 30/Oct/18 21:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6859:
[BEAM-5875] Add missing dependency in test-utils module
URL: https://github.com/apache/beam/pull/6859#discussion_r229497636
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -23,6 +23,7 @@ description = "Apache Beam :: SDKs :: Java :: Test Utils"
dependencies {
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
+ shadow library.java.guava
Review comment:
This should be compile scope
From
https://github.com/apache/beam/blob/f20e90a65874945dbbeb33270cab2a91d619af03/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L533:
```
// By default, the shadow plugin is enabled to perform shading of
commonly found dependencies.
// Because of this it is important that dependencies are added to the
correct configuration.
// Dependencies should fall into one of these four configurations:
// * compile - Required during compilation or runtime of the main
source set.
// This configuration represents all dependencies that
much also be shaded away
// otherwise the generated Maven pom will be missing
this dependency.
// * shadow - Required during compilation or runtime of the main
source set.
// Will become a runtime dependency of the generated
Maven pom.
// * testCompile - Required during compilation or runtime of the test
source set.
// This must be shaded away in the shaded test jar.
// * shadowTest - Required during compilation or runtime of the test
source set.
// TODO: Figure out whether this should be a test scope
dependency
// of the generated Maven pom.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160880)
Time Spent: 2h 20m (was: 2h 10m)
> Nexmark perf tests fail due to NoClassDefFoundError for Iterables.
> ------------------------------------------------------------------
>
> Key: BEAM-5875
> URL: https://issues.apache.org/jira/browse/BEAM-5875
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Henning Rohde
> Assignee: Kenneth Knowles
> Priority: Critical
> Labels: currently-failing
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> https://scans.gradle.com/s/vjkiys2xc3age/console-log?task=:beam-sdks-java-nexmark:run
> I see:
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/beam/repackaged/beam_sdks_java_test_utils/com/google/common/collect/Iterables
> at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:128)
> at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.currentPerf(NexmarkLauncher.java:250)
> at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:435)
> at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.collect.Iterables
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 13 more
> PRs for the first red run:
> [BEAM-5716] Move nexmark to "testing" directory in java sdk (commit: 0074138)
> (detail / githubweb)
> [BEAM-5716] Move load-tests code to "testing" directory in java sdk (commit:
> 6674c9d) (detail / githubweb)
> [BEAM-5716] Create module for testing utils (commit: 0628951) (detail /
> githubweb)
> [BEAM-5716] Extract MetricReader class, test it and use in Nexmark code
> (commit: 69730fc) (detail / githubweb)
> [BEAM-5355] Use MetricsReader in GroupByKeyLoadTest (commit: 7374eb6) (detail
> / githubweb)
> Łukasz -- would you mind taking a look? Looks like a shading issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
