[
https://issues.apache.org/jira/browse/BEAM-3709?focusedWorklogId=160918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160918
]
ASF GitHub Bot logged work on BEAM-3709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 23:30
Start Date: 30/Oct/18 23:30
Worklog Time Spent: 10m
Work Description: youngoli closed pull request #6128: [BEAM-3709]
Updating combine w/ side input translation in python.
URL: https://github.com/apache/beam/pull/6128
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/transforms/core.py
b/sdks/python/apache_beam/transforms/core.py
index bbd78342a7f..c6d5008ed87 100644
--- a/sdks/python/apache_beam/transforms/core.py
+++ b/sdks/python/apache_beam/transforms/core.py
@@ -1358,6 +1358,16 @@ def expand(self, pcoll):
*args, **kwargs)
def to_runner_api_parameter(self, context):
+ # Note: Although this conditional seems identical to the one below it
+ # (if self.args or self.kwargs), there are cases where that condition
+ # triggers when there are no side inputs, so both of these conditionals
+ # are necessary.
+ if self.side_inputs:
+ args, kwargs = util.insert_values_in_args(self.args, self.kwargs,
+ self.side_inputs)
+ return (ParDo(CombineValuesDoFn(None, self.fn, None), *args, **kwargs)
+ .to_runner_api_parameter(context))
+
if self.args or self.kwargs:
from apache_beam.transforms.combiners import curry_combine_fn
combine_fn = curry_combine_fn(self.fn, self.args, self.kwargs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160918)
Time Spent: 3h 40m (was: 3.5h)
> Implement the portable lifted Combiner transforms in Python SDK
> ---------------------------------------------------------------
>
> Key: BEAM-3709
> URL: https://issues.apache.org/jira/browse/BEAM-3709
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, sdk-py-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Python SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
