[ 
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=161201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161201
 ]

ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Oct/18 16:15
            Start Date: 31/Oct/18 16:15
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #6899: 
Revert "[BEAM-5299] Define max timestamp for global window in proto (…
URL: https://github.com/apache/beam/pull/6899#discussion_r229765589
 
 

 ##########
 File path: sdks/java/core/build.gradle
 ##########
 @@ -51,8 +51,6 @@ test {
 }
 
 dependencies {
-  // Required to load constants from the model, e.g. max timestamp for global 
window
-  shadow project(path: ":beam-model-pipeline", configuration: "shadow")
 
 Review comment:
   I don't believe this to be the culprit.
   
   The issue is that Dataflow has an internal container image that contains 
classes that were built from a previous source version. These classes become 
incompatible with versions submitted from "HEAD".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 161201)
    Time Spent: 8.5h  (was: 8h 20m)

> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
>                 Key: BEAM-5299
>                 URL: https://issues.apache.org/jira/browse/BEAM-5299
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
>            Reporter: Luke Cwik
>            Assignee: Maximilian Michels
>            Priority: Minor
>              Labels: portability
>          Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the 
> max timestamps within proto to be shared across different languages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to