[
https://issues.apache.org/jira/browse/BEAM-5922?focusedWorklogId=161241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161241
]
ASF GitHub Bot logged work on BEAM-5922:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/18 17:31
Start Date: 31/Oct/18 17:31
Worklog Time Spent: 10m
Work Description: jklukas commented on a change in pull request #6892:
[BEAM-5922] Refactor Map, FlatMap, and Filter on MapperBase
URL: https://github.com/apache/beam/pull/6892#discussion_r229795011
##########
File path:
runners/spark/src/test/java/org/apache/beam/runners/spark/SparkRunnerDebuggerTest.java
##########
@@ -81,14 +81,14 @@ public void debugBatchPipeline() {
"sparkContext.parallelize(Arrays.asList(...))\n"
+ "_.mapPartitions("
+ "new
org.apache.beam.runners.spark.examples.WordCount$ExtractWordsFn())\n"
- + "_.mapPartitions(new
org.apache.beam.sdk.transforms.Contextful())\n"
+ + "_.mapPartitions(new
org.apache.beam.sdk.transforms.MapperBase$1())\n"
Review comment:
It's not clear to me why this PR makes this show up as `MapperBase$1` rather
than `Contextful`. Is this potentially pointing to a scope leak causing more to
get serialized than necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 161241)
Time Spent: 1h (was: 50m)
> Common base class for FlatMapElements, MapElements, and Filter
> --------------------------------------------------------------
>
> Key: BEAM-5922
> URL: https://issues.apache.org/jira/browse/BEAM-5922
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Jeff Klukas
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> By having FlatMapElements, MapElements, and Filter all inherit from a common
> MapperBase, we can reduce code duplication between these three classes for
> better consistency in future changes. There should be no change in
> functionality or public interface with this change.
> In particular, this change will simplify the implementation of failure
> handling
> across these transforms in https://issues.apache.org/jira/browse/BEAM-5638
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
