[
https://issues.apache.org/jira/browse/BEAM-5932?focusedWorklogId=161670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161670
]
ASF GitHub Bot logged work on BEAM-5932:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/18 18:04
Start Date: 01/Nov/18 18:04
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6907:
[BEAM-5932] Re-enable Beam SDK deprecation warnings.
URL: https://github.com/apache/beam/pull/6907#discussion_r230140443
##########
File path: sdks/python/apache_beam/utils/annotations.py
##########
@@ -88,6 +88,14 @@ def exp_multiply(arg1, arg2):
from functools import wraps
+class BeamDeprecationWarning(DeprecationWarning):
+ """Beam-specific deprecation warnings."""
+
+
+# Don't ignore BeamDeprecationWarnings.
+warnings.simplefilter('once', BeamDeprecationWarning)
Review comment:
What does `'once'` do? If there are 2 warnings of the same type does it only
show one of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 161670)
Time Spent: 40m (was: 0.5h)
> Python SDK deprecation warnings are broken
> ------------------------------------------
>
> Key: BEAM-5932
> URL: https://issues.apache.org/jira/browse/BEAM-5932
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Blocker
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/pull/6687]
> removed the line
> {code:python}
> warnings.simplefilter("once"){code}
> from annotations.py.
> This disables all deprecation warnings.
> Please fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
