[
https://issues.apache.org/jira/browse/BEAM-5946?focusedWorklogId=162155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162155
]
ASF GitHub Bot logged work on BEAM-5946:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/18 23:57
Start Date: 02/Nov/18 23:57
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6915: [BEAM-5946] Upgrade
google-apitools to 0.5.24
URL: https://github.com/apache/beam/pull/6915
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/container/base_image_requirements.txt
b/sdks/python/container/base_image_requirements.txt
index 162fb932784..397498d9b05 100644
--- a/sdks/python/container/base_image_requirements.txt
+++ b/sdks/python/container/base_image_requirements.txt
@@ -45,7 +45,7 @@ typing==3.6.1
nose==1.3.7
# GCP extra features
-google-apitools==0.5.20
+google-apitools==0.5.24
googledatastore==7.0.1
google-cloud-pubsub==0.35.4
google-cloud-bigquery==1.6.0
diff --git a/sdks/python/setup.py b/sdks/python/setup.py
index 4d5e227163c..7ebecd32664 100644
--- a/sdks/python/setup.py
+++ b/sdks/python/setup.py
@@ -137,8 +137,8 @@ def get_version():
]
GCP_REQUIREMENTS = [
- # oauth2client >=4 only works with google-apitools>=0.5.18.
- 'google-apitools>=0.5.18,<=0.5.20',
+ # google-apitools 0.5.23 and above has important Python 3 supports.
+ 'google-apitools>=0.5.23,<=0.5.24',
'proto-google-cloud-datastore-v1>=0.90.0,<=0.90.4',
'googledatastore==7.0.1; python_version < "3.0"',
'google-cloud-pubsub==0.35.4',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162155)
Time Spent: 20m (was: 10m)
> Upgrade google-apitools to 0.5.24
> ---------------------------------
>
> Key: BEAM-5946
> URL: https://issues.apache.org/jira/browse/BEAM-5946
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Affects Versions: 2.9.0
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Python google-apitools library contains important support that fix Python 3
> incompatible issue in 0.5.23 and above. In order to make Python SDK
> compatible with Python 3, we want to upgrade it to the latest version
> (0.5.24).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
