[
https://issues.apache.org/jira/browse/BEAM-4124?focusedWorklogId=162766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162766
]
ASF GitHub Bot logged work on BEAM-4124:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/18 22:29
Start Date: 05/Nov/18 22:29
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6948:
[BEAM-4124] datamgr.go:Remove chunksize constraint
URL: https://github.com/apache/beam/pull/6948#discussion_r230937835
##########
File path: sdks/go/pkg/beam/core/runtime/harness/datamgr.go
##########
@@ -370,14 +370,11 @@ func (w *dataWriter) Flush() error {
}
func (w *dataWriter) Write(p []byte) (n int, err error) {
- if len(p) > chunkSize {
- panic(fmt.Sprintf("Incoming message too big for transport: %d >
%d", len(p), chunkSize))
- }
-
if len(w.buf)+len(p) > chunkSize {
+ l := len(w.buf)
// We can't fit this message into the buffer. We need to flush
the buffer
if err := w.Flush(); err != nil {
- return 0, err
+ return 0, fmt.Errorf("datamgr.go: error flushing buffer
of length %d: %v", l, err)
Review comment:
Curios, why not totally drop `l` and use `len(w.buf)` directly as an
argument to `Errorf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162766)
Time Spent: 0.5h (was: 20m)
> Support elements larger than 4 MB
> ---------------------------------
>
> Key: BEAM-4124
> URL: https://issues.apache.org/jira/browse/BEAM-4124
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Cody Schroeder
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Go SDK harness is limited by a gRPC message size limit of 4 MB.
> https://github.com/apache/beam/blob/4a32353/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L31
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
