[
https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=163166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163166
]
ASF GitHub Bot logged work on BEAM-5304:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/18 19:14
Start Date: 06/Nov/18 19:14
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6904: [BEAM-5304] Adding
default and dynamic ports to ULR.
URL: https://github.com/apache/beam/pull/6904
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java
index 207deeff9f3..77b1028844c 100644
---
a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java
+++
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/job/ReferenceRunnerJobServer.java
@@ -113,7 +113,7 @@ public void stop() {
ServerFactory serverFactory,
ReferenceRunnerJobService service)
throws IOException {
- if (configuration.port < 0) {
+ if (configuration.port <= 0) {
return GrpcFnServer.allocatePortAndCreateFor(service, serverFactory);
}
return GrpcFnServer.create(
@@ -126,8 +126,8 @@ public void stop() {
@Option(
name = "-p",
aliases = {"--port"},
- usage = "The local port to expose the server on"
+ usage = "The local port to expose the server on. 0 to use a dynamic
port. (Default: 8099)"
)
- private int port = -1;
+ private int port = 8099;
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163166)
Time Spent: 3.5h (was: 3h 20m)
> Support running user pipelines with the Universal Local Runner in Java.
> -----------------------------------------------------------------------
>
> Key: BEAM-5304
> URL: https://issues.apache.org/jira/browse/BEAM-5304
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> In order to aid testing, devs should be able to write pipelines and then
> easily run them with the ULR. The Flink runner seems to have this
> functionality, so the implementation could be based on that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
