[
https://issues.apache.org/jira/browse/BEAM-6010?focusedWorklogId=163456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163456
]
ASF GitHub Bot logged work on BEAM-6010:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/18 14:17
Start Date: 07/Nov/18 14:17
Worklog Time Spent: 10m
Work Description: aromanenko-dev closed pull request #6964: [BEAM-6010]
Deprecate KafkaIO withTimestampFn().
URL: https://github.com/apache/beam/pull/6964
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/TimestampPolicyFactory.java
b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/TimestampPolicyFactory.java
index d554c173eee..4d7497e6e02 100644
---
a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/TimestampPolicyFactory.java
+++
b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/TimestampPolicyFactory.java
@@ -92,7 +92,14 @@
new CustomTimestampPolicyWithLimitedDelay<>(timestampFunction,
maxDelay, previousWatermark);
}
- /** Used by the Read transform to support old timestamp functions API. */
+ /**
+ * Used by the Read transform to support old timestamp functions API. This
exists only to support
+ * other deprecated API {@link
KafkaIO.Read#withTimestampFn(SerializableFunction)}.<br>
+ * TODO(rangadi): Make this package private or remove it. It was never meant
to be public.
+ *
+ * @deprecated Use @{@link CustomTimestampPolicyWithLimitedDelay}.
+ */
+ @Deprecated
static <K, V> TimestampPolicyFactory<K, V> withTimestampFn(
final SerializableFunction<KafkaRecord<K, V>, Instant> timestampFn) {
return (tp, previousWatermark) -> new TimestampFnPolicy<>(timestampFn,
previousWatermark);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163456)
Time Spent: 10m
Remaining Estimate: 0h
> Deprecate KafkaIO withTimestampFn()
> -----------------------------------
>
> Key: BEAM-6010
> URL: https://issues.apache.org/jira/browse/BEAM-6010
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka
> Affects Versions: 2.8.0
> Reporter: Alexey Romanenko
> Assignee: Raghu Angadi
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
