[
https://issues.apache.org/jira/browse/BEAM-5931?focusedWorklogId=164009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164009
]
ASF GitHub Bot logged work on BEAM-5931:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/18 18:15
Start Date: 08/Nov/18 18:15
Worklog Time Spent: 10m
Work Description: HuangLED commented on a change in pull request #6966:
[BEAM-5931] Add worker jar to integrationTest targets.
URL: https://github.com/apache/beam/pull/6966#discussion_r232005895
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1139,7 +1140,23 @@ artifactId=${project.name}
outputs.upToDateWhen { false }
include "**/*IT.class"
- systemProperties.beamTestPipelineOptions =
configuration.integrationTestPipelineOptions
+
+ def pipelineOptionsString =
configuration.integrationTestPipelineOptions
+ if(pipelineOptionsString &&
configuration.runner?.equalsIgnoreCase('dataflow')) {
+
project.evaluationDependsOn(":beam-runners-google-cloud-dataflow-java-legacy-worker")
+ def allOptionsList = (new
JsonSlurper()).parseText(pipelineOptionsString)
+ def dataflowWorkerJar = project.findProperty('dataflowWorkerJar') ?:
+
project.project(":beam-runners-google-cloud-dataflow-java-legacy-worker").shadowJar.archivePath
+
+ allOptionsList.addAll([
Review comment:
I assume if there are duplicated args/options, the place inside pipeline
that processes all the PipelineOptions will take care of the duplication. It
would be too much redundancy if we need to do that in every gradle task.
Correct me if I am wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 164009)
Time Spent: 6.5h (was: 6h 20m)
> Rollback PR/6899
> ----------------
>
> Key: BEAM-5931
> URL: https://issues.apache.org/jira/browse/BEAM-5931
> Project: Beam
> Issue Type: Task
> Components: beam-model, runner-dataflow
> Reporter: Luke Cwik
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> To rollback this change, one must either:
> 1) Update nexmark / perf test framework to use Dataflow worker jar.
> This requires adding the
> {code}
> "--dataflowWorkerJar=${dataflowWorkerJar}",
> "--workerHarnessContainerImage=",
> {code}
> when running the tests.
> OR
> 2) Update the dataflow worker image with code that contains the rollback of
> PR/6899 and then rollback PR/6899 in Github with the updated Dataflow worker
> image.
> #1 is preferable since we will no longer have tests running that don't use a
> Dataflow worker jar built from Github HEAD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
