[
https://issues.apache.org/jira/browse/BEAM-5778?focusedWorklogId=163847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163847
]
ASF GitHub Bot logged work on BEAM-5778:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/18 09:16
Start Date: 08/Nov/18 09:16
Worklog Time Spent: 10m
Work Description: kkucharc commented on a change in pull request #6943:
[BEAM-5778] Add integrations of Metrics API to Big Query for SyntheticcSources
load tests in Python SDK
URL: https://github.com/apache/beam/pull/6943#discussion_r231810486
##########
File path: sdks/python/apache_beam/testing/load_tests/co_group_by_key_test.py
##########
@@ -132,15 +148,13 @@ def testCoGroupByKey(self):
({INPUT_TAG: pc1, CO_INPUT_TAG: pc2}
| 'CoGroupByKey: ' >> beam.CoGroupByKey()
| 'Consume Joined Collections' >> beam.ParDo(self._Ungroup())
- | 'Measure time' >> beam.ParDo(MeasureTime())
+ | 'Measure time' >> beam.ParDo(MeasureTime(NAMESPACE))
)
result = p.run()
result.wait_until_finish()
- metrics = result.metrics().query()
Review comment:
This is moved to utils. While parsing they are written to the console -
[please check
here](https://github.com/apache/beam/blob/e56f1b93d6d54aede3ac4a6c72afea6987a1a530/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py#L1040).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163847)
Time Spent: 2h 40m (was: 2.5h)
> Add integrations of Metrics API to Big Query for SyntheticSources load tests
> in Python SDK
> ------------------------------------------------------------------------------------------
>
> Key: BEAM-5778
> URL: https://issues.apache.org/jira/browse/BEAM-5778
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Right now Metrics API collects basic metrics of load tests of
> SyntheticSources (Python SDK). It should be collected in BigQuery for
> presenting it on performance dashboards.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
