[
https://issues.apache.org/jira/browse/BEAM-6026?focusedWorklogId=164110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164110
]
ASF GitHub Bot logged work on BEAM-6026:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/18 22:22
Start Date: 08/Nov/18 22:22
Worklog Time Spent: 10m
Work Description: swegner commented on issue #6989: [BEAM-6026] Add
website pages with SDK dependencies
URL: https://github.com/apache/beam/pull/6989#issuecomment-437177554
Ah ha! I am able to repro locally (`./gradlew -p website/ testWebsite`), and
inspecting the generated HTML in
`build/website/generated-local-content/documentation/sdks/java-dependencies/index.html`,
I can see this is failing for link:
```html
<a
href="https://github.com/apache/beam/edit/master/website/src/documentation/sdks/java-dependencies.md";>
<i class="far fa-edit fa-lg" alt="Edit on GitHub" title="Edit on
GitHub"></i>
</a>
```
This is the great "Edit" button that @alanmyrvold recently added. It makes
sense that the link won't work until the page is committed to GitHub. So this
will always fail for new pages.
I suggest we disable these links from the link checker; the easiest way to
do that would be to add `data-proofer-ignore` to the `<a>` tag. See
[html-proofer Ignoring
Content](https://github.com/gjtorikian/html-proofer#ignoring-content). I'll
open a PR with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 164110)
Time Spent: 0.5h (was: 20m)
> Add new pages that list SDK dependencies
> ----------------------------------------
>
> Key: BEAM-6026
> URL: https://issues.apache.org/jira/browse/BEAM-6026
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Melissa Pashniak
> Assignee: Melissa Pashniak
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
